[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anurag-rajawat
Once this PR has been reviewed and has the lgtm label, please assign rikatz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Welcome @anurag-rajawat!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @anurag-rajawat. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Great start. Can you add an e2e test that exercises using the njs model?

Great start. Can you add an e2e test that exercises using the njs model?

This may have to wait till we release a new nignx base image. We do rebuild the controller in all e2e but not the nginx base.

/ok-to-test

/kind feature
/priority backlog

We do build the nginx image, so we can add some e2e test for njs.
https://github.com/kubernetes/ingress-nginx/actions/runs/11776116543/job/32797881046#step:9:1

Hey @strongjz, should we proceed with further changes?

Hey @strongjz, should we proceed with further changes?

Let's chat after our maintainers talk tomorrow. We've got plans for things going forward.

Also need to rebase to get the go lint ci 0207d18

/triage accepted
/priority important-soon

We need this to start removing some 3rd party modules from NGINX and some one-line openresty scripts that could be an njs script.

I think for now, only have the module but not load it nor hide it behind a flag is enough

/hold cancel

Still we need to fix the NGINX build on main first for the v1.12 release.

/hold

Also this branch is out-of-date and needs to be rebased.

@Gacko I am not following the relation here. Is main branch broken, or are you cutting 1.12 from a release branch?

What is broken? What is the status of the fix?

Every branch is broken because we are doing an apk upgrade in the build.sh and we are building the NGINX base image for the release branches from main.

Specifically what is broken from the upgrade? Which part of the build?

There are compilation failures, I'm already working on this. You can see the release-cloud-build branch for it. Anyway: Please just postpone any changes to the NGINX base image until we got release v1.12 out.

Just keep in mind: What ever you change, we won't release it before v1.13 anyway as there already is a v1.12 on its way and we first need to fix this. So new features like this, cross plane or NGINX v1.27.1 are not urgent and can stay unmerged for now.

The idea is not to release on v1.12 any of crossplane or njs changes, I was more willing to not block changes that long and trying to understand what's going on the build.

I will take a look into your branch and recent cloud builds to understand what's going on

Of course we are not planning to release Crossplane or NJS on v1.12, but currently the NGINX base image Cloud Build is broken on all the branches and I'd like to prevent any changes to the NGINX base image before we haven't figured out what's wrong, also because we normally build the NGINX base image for all branches from the main branch. So merging anything to the main branch could possibly affect this.

Ideally we are building the NGINX base image per branch, but this is something we need to figure out via well thought release engineering and versions in the TAG file across branches.